emkornfield commented on a change in pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#discussion_r467353299
##########
File path: cpp/src/arrow/python/python_to_arrow.cc
##########
@@ -191,10 +191,11 @@ struct ValueConverter<Date64Type> {
template <>
struct ValueConverter<Time32Type> {
- static inline Result<int32_t> FromPython(PyObject* obj, TimeUnit::type unit)
{
+ static inline Result<int32_t> FromPython(PyObject* obj, TimeUnit::type unit,
+ bool /*ignore_timezone*/) {
Review comment:
My thought here was this parameter will only be need until the next
release, so it would be better to add it here and then remove it without the
need to introduce options. We can introduce options though if you feel
strongly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
