vertexclique commented on a change in pull request #7917:
URL: https://github.com/apache/arrow/pull/7917#discussion_r467500372
##########
File path: rust/parquet/Cargo.toml
##########
@@ -52,4 +53,4 @@ zstd = "0.5"
arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" }
[features]
-default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd"]
+default = ["arrow", "snap", "brotli", "flate2", "lz4", "zstd", "base64"]
Review comment:
> I assume the various compression types could depend on what the
parquet source being read supports. In that case, could a user run the risk of
not being able to read in a file because it supports compression?
Yes, that's true, for having less build dependencies for default set yet
another idea (FWIW bikeshedding):
```
default = ["core"]
core = ["arrow", "base64"]
comp_snap = ["snap"]
comp_brotli = ["brotli"]
comp_flate = ["flate2"]
comp_lz4 = ["lz4"]
comp_zstd = ["zstd"]
```
and users add their desired compression to enable. Just tested this, it
passes parquet test on master as like that (without base64).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
