corleyma commented on a change in pull request #7803:
URL: https://github.com/apache/arrow/pull/7803#discussion_r467822801
##########
File path: cpp/src/arrow/filesystem/s3fs.h
##########
@@ -62,10 +62,12 @@ struct ARROW_EXPORT S3Options {
void ConfigureAnonymousCredentials();
/// Configure with explicit access and secret key.
- void ConfigureAccessKey(const std::string& access_key, const std::string&
secret_key);
+ void ConfigureAccessKey(const std::string& access_key, const std::string&
secret_key,
+ const std::string& session_token = "");
std::string GetAccessKey() const;
std::string GetSecretKey() const;
+ std::string GetSessionToken() const;
Review comment:
I added C++ tests to `s3fs_test.cc` to cover these changes.
Unfortunately, adding support for STS-like temporary credentials to Minio
involves addition of another dependency, Keycloak. I spent a bit of time
reading relevant docs but could not seem to find a programmatic way to
replicate the desired behavior (the Keycloak guides I found were very
UI-driven).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
