kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r467915870
##########
File path: cpp/src/arrow/type.h
##########
@@ -29,6 +29,7 @@
#include "arrow/result.h"
#include "arrow/type_fwd.h" // IWYU pragma: export
+#include "arrow/util/bit_util.h"
Review comment:
Just do you want not to include `bit_util.h` in `type.h`. There are
possible two ways.
One way is to include one of the following header files that explicitly
include `bit_util.h`.
- buffer_builder.h
- type_traits.h
- visitor_inline.h
Or, try to move the definition of `class Endianness`. On the other hand, the
header file that will newly define `class Endianness` requires including
`bit_util.h`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
