kszucs commented on a change in pull request #7816:
URL: https://github.com/apache/arrow/pull/7816#discussion_r468021657



##########
File path: python/pyarrow/tests/test_types.py
##########
@@ -252,6 +255,121 @@ def test_is_primitive():
     assert not types.is_primitive(pa.list_(pa.int32()))
 
 
[email protected](('tz', 'expected'), [
+    (pytz.utc, 'UTC'),
+    (pytz.timezone('Europe/Paris'), 'Europe/Paris'),
+    (pytz.FixedOffset(180), '+03:00'),
+    (datetime.timezone.utc, '+00:00'),
+    (datetime.timezone(datetime.timedelta(hours=1, minutes=30)), '+01:30')
+])
+def test_tzinfo_to_string(tz, expected):
+    assert pa.lib.tzinfo_to_string(tz) == expected
+
+
[email protected](sys.version_info <= (3, 7), reason=(
+    "Since python 3.7 the UTC offset for datetime.timezone is not restricted "

Review comment:
       Removed the skip since we validate ourself that the timedelta has whole 
number of minutes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to