andygrove commented on a change in pull request #7916:
URL: https://github.com/apache/arrow/pull/7916#discussion_r469306474
##########
File path: rust/datafusion/src/sql/parser.rs
##########
@@ -77,20 +77,20 @@ pub struct DFParser {
impl DFParser {
/// Parse the specified tokens
- pub fn new(sql: &str) -> Result<Self, ParserError> {
- let dialect = GenericDialect {};
- let mut tokenizer = Tokenizer::new(&dialect, sql);
+ pub fn new(sql: &str, dialect: &dyn Dialect) -> Result<Self, ParserError> {
Review comment:
Rather than make this breaking change, let's add a new constructor named
`with_dialect` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
