michalursa commented on a change in pull request #12067: URL: https://github.com/apache/arrow/pull/12067#discussion_r826472267
########## File path: cpp/src/arrow/compute/exec/vector_hash_test.cc ########## @@ -0,0 +1,234 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <gmock/gmock-matchers.h> + +#include <chrono> +#include <map> +#include <set> +#include "arrow/compute/exec/key_hash.h" +#include "arrow/compute/exec/test_util.h" +#include "arrow/compute/exec/util.h" +#include "arrow/util/cpu_info.h" + +namespace arrow { +namespace compute { + +void TestVectorHashImp(Random64Bit& random, bool use_32bit_hash, bool use_varlen_input, Review comment: Bit, null, HashMultiColumn are exercised by all hash join and hash group by tests, so the bugs in these areas would be caught there. Of course it is easier to debug failures in a smaller scenario, but bit, null, HashMultiColumn are build on top of core xhh hash arithmetic, so debugging from join or group by test is not unreasonably difficult. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
