alamb commented on a change in pull request #1987:
URL: https://github.com/apache/arrow-datafusion/pull/1987#discussion_r826671084
##########
File path: datafusion/src/physical_plan/coalesce_batches.rs
##########
@@ -124,10 +124,10 @@ impl ExecutionPlan for CoalesceBatchesExec {
async fn execute(
&self,
partition: usize,
- runtime: Arc<RuntimeEnv>,
+ context: Arc<TaskContext>,
) -> Result<SendableRecordBatchStream> {
Ok(Box::pin(CoalesceBatchesStream {
- input: self.input.execute(partition, runtime).await?,
+ input: self.input.execute(partition, context).await?,
Review comment:
Since `ExecutionContext` is currently used for something quite different
in DataFusion (what this PR renames to `SessionContext`), defining it to be
something else may be quite confusing
Perhaps something like `RunContext` or `RuntimeContext` would be less vague
than `TaskContext` but also not redefine the `ExecutionContext` term?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
