lidavidm commented on a change in pull request #12628:
URL: https://github.com/apache/arrow/pull/12628#discussion_r826970540
##########
File path: cpp/src/arrow/flight/flight_test.cc
##########
@@ -81,6 +81,7 @@ TEST_F(GrpcConnectivityTest, GetPort) { TestGetPort(); }
TEST_F(GrpcConnectivityTest, BuilderHook) { TestBuilderHook(); }
TEST_F(GrpcConnectivityTest, Shutdown) { TestShutdown(); }
TEST_F(GrpcConnectivityTest, ShutdownWithDeadline) {
TestShutdownWithDeadline(); }
+TEST_F(GrpcConnectivityTest, BrokenConnection) { TestBrokenConnection(); }
Review comment:
I added convenience macros. GTest's value-parameterized tests would work
better for this but I couldn't get the Windows build to work out (GTest thought
that the same test fixture had been defined multiple times and would error on
startup)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
