jonkeane commented on pull request #12537:
URL: https://github.com/apache/arrow/pull/12537#issuecomment-1068020835
> Thanks for addressing my comments. A few remaining nits but I'm content
with the c++ part. @jonkeane do you need me to take a look at the R?
If you wouldn't mind, that would be fabulous (especially the C++ in the r
directory...) I've still not been able to get the `tpch_dbgen_write` function
to work (even with my hard coded version here) — but I haven't been able to
track down where it's going wrong. I had put in a few messages to try, and it
appears that it's getting to producing, but never completes and I get
segfaults:
```
> arrow:::tpch_dbgen_write("lineitem", scale_factor = 1, path = "~/Desktop")
Just after consume
Just after validate
Just after start
*** caught segfault ***
*** caught segfault ***
address 0x0, cause 'memory not mapped'
*** caught segfault ***
*** caught segfault ***
*** caught segfault ***
address 0x0, cause 'memory not mapped'
address 0x0, cause 'memory not mapped'
address 0x0, cause 'memory not mapped'
address 0x0, cause 'memory not mapped'
*** caught segfault ***
address 0x0, cause 'memory not mapped'
*** caught segfault ***
address 0x0, cause 'memory not mapped'
*** caught segfault ***
address 0x0, cause 'memory not mapped'
```
I've also attached [a crash
report](https://github.com/apache/arrow/files/8253958/tpch_write_crash.txt)
We can move those out of this PR if we want to get this done and merge it
separately (though I'll probably still need some C++ help to figure out what's
going on with that if we do it separately)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
