nevi-me commented on pull request #7917: URL: https://github.com/apache/arrow/pull/7917#issuecomment-674176859
> ... I think this is stacked on another PR though: do we need to get the other one reviewed first? @sunchao it's a bit messy, but it's one PR. The changes are below: * arrow_reader.rs - added a roundtrip test (https://github.com/apache/arrow/pull/7917/files?file-filters%5B%5D=.toml#diff-4c103051156d7b901fad8d9e26104932R310) to avoid importing the reader and writer into the `schema.rs` file. I opted to put the test in reader because it results in the fewest imports (only need the `ArrowWriter`). * arrow_writer.rs - implements the schema serialisation * schema.rs - implements schema deserialisation * properties.rs - change to allow mutating metadata ____ Let me refactor the above quickly, as I now see that I can move both serialisation and deserialisation to `schema.rs` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
