jonkeane commented on a change in pull request #12506:
URL: https://github.com/apache/arrow/pull/12506#discussion_r827091323



##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -974,3 +974,173 @@ test_that("date() errors with unsupported inputs", {
     regexp = "Unsupported cast from double to date32 using function 
cast_date32"
   )
 })
+
+test_that("difftime works correctly", {
+  test_df <- tibble(
+    time1 = as.POSIXct(
+      c("2021-02-20", "2021-07-31", "2021-10-30", "2021-01-31")
+    ),

Review comment:
       Having pure dates as one of the two time columns we use for general 
checking is a bit confusing — maybe we should add a comment that these can also 
be times (or include a few that have times to show that we can mix and match in 
those argument positions)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to