viirya commented on a change in pull request #1432:
URL: https://github.com/apache/arrow-rs/pull/1432#discussion_r827471258
##########
File path: arrow/src/array/array.rs
##########
@@ -629,7 +629,9 @@ pub unsafe fn make_array_from_raw(
schema: *const ffi::FFI_ArrowSchema,
) -> Result<ArrayRef> {
let array = ffi::ArrowArray::try_from_raw(array, schema)?;
- let data = ArrayData::try_from(array)?;
+ let data = ArrayData::try_from(&array)?;
+ // Avoid dropping the `Box` pointers and trigger the `release` mechanism.
+ let _ = ffi::ArrowArray::into_raw(array);
Review comment:
It looks close to previous suggestion `Arc::from` as it also copies
bytes from source structs. But it causes SIGSEGV. I will try to test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
