wangfenjin commented on a change in pull request #1449:
URL: https://github.com/apache/arrow-rs/pull/1449#discussion_r827696117
##########
File path: arrow/src/ffi.rs
##########
@@ -781,11 +781,19 @@ impl ArrowArray {
.to_string(),
));
};
- let ffi_array = (*array).clone();
- let ffi_schema = (*schema).clone();
+
+ let array_mut = array as *mut FFI_ArrowArray;
+ let schema_mut = schema as *mut FFI_ArrowSchema;
+
+ let array_data = std::ptr::replace(array_mut, FFI_ArrowArray::empty());
Review comment:
Or we can export to the memory allocate by users, so we don't need to
bother that
```rust
/// exports [ArrowArray] to the C Data Interface
pub unsafe fn export_into_raw(&self, mut out_array: *const
FFI_ArrowArray, mut out_schema: *const FFI_ArrowSchema) -> Result<()> {
let _ = std::ptr::replace(&mut out_schema,
Arc::into_raw(self.schema.clone()));
let _ = std::ptr::replace(&mut out_array,
Arc::into_raw(self.array.clone()));
Ok(())
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
