lidavidm commented on a change in pull request #12639:
URL: https://github.com/apache/arrow/pull/12639#discussion_r827934389
##########
File path: python/setup.py
##########
@@ -421,7 +421,8 @@ def _bundle_cython_cpp(self, name, lib_path):
def _failure_permitted(self, name):
if name == '_parquet' and not self.with_parquet:
return True
- if name == '_parquet_encryption' and not self.with_parquet_encryption:
+ if name == '_parquet_encryption' and \
+ not (self.with_parquet and self.with_parquet_encryption):
Review comment:
We could go that way, yes, and have one implicitly enable the other. We
could also just fix the CI script not to have conflicting defaults:
https://github.com/apache/arrow/blob/a32f454d86560ab357b419273bb08678e1632d30/ci/scripts/python_build.sh#L60-L61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
