jorisvandenbossche commented on a change in pull request #12452:
URL: https://github.com/apache/arrow/pull/12452#discussion_r827983132



##########
File path: python/pyarrow/table.pxi
##########
@@ -2453,6 +2453,49 @@ cdef class Table(_PandasConvertible):
 
         return table
 
+    def join(self, keys, right_table, right_keys=None, join_type="left outer",

Review comment:
       We should maybe switch the order of the `keys` and `right_table` 
arguments. All the other dataframe libraries I was checking have the other 
table as first argument




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to