wjones127 commented on a change in pull request #12633:
URL: https://github.com/apache/arrow/pull/12633#discussion_r828306668
##########
File path: r/R/config.R
##########
@@ -40,5 +42,7 @@ io_thread_count <- function() {
#' @param num_threads integer: New number of threads for thread pool
#' @export
set_io_thread_count <- function(num_threads) {
+ current_io_thread_count <- io_thread_count()
SetIOThreadPoolCapacity(as.integer(num_threads))
+ invisible(current_io_thread_count)
Review comment:
Yeah I actually had to spend a couple minutes parsing the tests to
understand that was intended behavior. Maybe it's worth rewriting the tests to
make that more obvious. For example, rewrite
```r
expect_identical(set_io_thread_count(1), current_io_thread_count)
```
to
```r
previous_count <- set_io_thread_count(1)
expect_identical(previous_count, current_io_thread_count)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
