rok commented on a change in pull request #12612:
URL: https://github.com/apache/arrow/pull/12612#discussion_r828507912
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -240,11 +240,11 @@ struct SubtractCheckedDate32 {
}
};
-template <bool is_32bit, int64_t multiple>
+template <bool left_is_32bit, int64_t multiple>
struct AddTimeDuration {
template <typename T, typename Arg0, typename Arg1>
- static enable_if_t<is_32bit, T> Call(KernelContext*, Arg0 left, Arg1 right,
- Status* st) {
+ static enable_if_t<(!std::is_same<Arg0, Arg1>::value && left_is_32bit), T>
Call(
+ KernelContext*, Arg0 left, Arg1 right, Status* st) {
T result = arrow::internal::SafeSignedAdd(left, static_cast<T>(right));
Review comment:
Done. Would you suggest to do this for `SubtractTimeDuration` and
`SubtractTimeDurationChecked` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
