zeroshade commented on pull request #12158: URL: https://github.com/apache/arrow/pull/12158#issuecomment-1071247615
@emkornfield Delta and replacement dictionaries are handled at the bottom of the `readDictionary` function by calling `AddDelta` and `AddOrReplace` on the `memo` object, while the `memo` object is used when constructing the record batches with those dictionaries. I've added the error case for IPC files to error out on a replacement dictionary. That should cover everything as far as I'm aware for now, and we're passing all the integration tests with dictionaries. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
