lidavidm commented on a change in pull request #12460:
URL: https://github.com/apache/arrow/pull/12460#discussion_r829361510
##########
File path: cpp/src/arrow/compute/api_vector.h
##########
@@ -522,6 +533,16 @@ Result<Datum> DictionaryEncode(
const DictionaryEncodeOptions& options =
DictionaryEncodeOptions::Defaults(),
ExecContext* ctx = NULLPTR);
+ARROW_EXPORT
+Result<std::shared_ptr<Array>> CumulativeSum(const Array& values,
+ CumulativeSumOptions& options,
+ ExecContext* ctx = NULLPTR);
Review comment:
I don't recall if/when we did this, but I would agree that we should at
least have `const Options&` (to follow the style guide), and providing default
options is more convenient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
