andygrove commented on a change in pull request #7969:
URL: https://github.com/apache/arrow/pull/7969#discussion_r471031743
##########
File path: rust/arrow/src/ipc/reader.rs
##########
@@ -651,19 +654,20 @@ impl<R: Read + Seek> RecordBatchReader for FileReader<R> {
self.schema.clone()
}
- fn next_batch(&mut self) -> Result<Option<RecordBatch>> {
Review comment:
The issue is that both DataFusion and Parquet implement the same
RecordBatchReader trait that requires `&mut self` and therefore requires the
use of mutexes. Maybe DataFusion should have its own trait instead. I'll try
that approach next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
