rok commented on a change in pull request #12464:
URL: https://github.com/apache/arrow/pull/12464#discussion_r829467326
##########
File path: python/pyarrow/_compute.pyx
##########
@@ -1458,10 +1458,12 @@ class StrptimeOptions(_StrptimeOptions):
unit : str
Timestamp unit of the output.
Accepted values are "s", "ms", "us", "ns".
+ raise_errors : boolean, default True
+ Raise on parsing errors.
Review comment:
Done.
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -1143,6 +1145,117 @@ struct Strftime {
};
#endif
+// ----------------------------------------------------------------------
+// Convert string representations of timestamps in arbitrary format to
timestamps
+
+static std::string GetZone(std::string format) {
Review comment:
Done as parameter.
##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -1590,7 +1705,13 @@ const FunctionDoc strftime_doc{
"does not exist on this system."),
{"timestamps"},
"StrftimeOptions"};
-
+const FunctionDoc strptime_doc(
+ "Parse timestamps",
+ ("For each string in `strings`, parse it as a timestamp.\n"
+ "The timestamp unit and the expected string pattern must be given\n"
+ "in StrptimeOptions. Null inputs emit null. If a non-null string\n"
+ "fails parsing, an error is returned by default."),
Review comment:
Done. Please check.
##########
File path: cpp/src/arrow/compute/api_scalar.h
##########
@@ -267,12 +267,17 @@ class ARROW_EXPORT StructFieldOptions : public
FunctionOptions {
class ARROW_EXPORT StrptimeOptions : public FunctionOptions {
public:
- explicit StrptimeOptions(std::string format, TimeUnit::type unit);
+ explicit StrptimeOptions(std::string format, TimeUnit::type unit,
+ bool raise_errors = true);
StrptimeOptions();
static constexpr char const kTypeName[] = "StrptimeOptions";
+ /// The desired format string.
std::string format;
+ /// The desired time resolution
TimeUnit::type unit;
+ /// Raise on parsing errors
Review comment:
Changed to `error_is_null`. How about `error_returns_null`?
##########
File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc
##########
@@ -27,6 +27,7 @@
#include <utf8proc.h>
#endif
+#include "arrow/compute/api.h"
Review comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
