jorgecarleitao commented on pull request #7972: URL: https://github.com/apache/arrow/pull/7972#issuecomment-674477784
I went through this, and it looks great. I admit I am still not fully familiar when to use Rc vs Arc yet (e.g. why nor Arc instead? because we do not expect the context to be sharable between threads?), so take that into account. I have an extra suggestion, that I pushed [here](https://github.com/jorgecarleitao/arrow/commit/521dd2be7644bb8b7bf5cb47164e1246bc45d13f). Essentially, with this change I think that we can remove `ExecutionContextSchemaProvider` altogether and let `ExecutionContextState` implement `SchemaProvider`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
