pitrou commented on a change in pull request #12636:
URL: https://github.com/apache/arrow/pull/12636#discussion_r831122417
##########
File path: format/Flight.proto
##########
@@ -298,6 +316,9 @@ message Location {
/*
* An opaque identifier that the service can use to retrieve a particular
* portion of a stream.
+ *
+ * Tickets are meant to be single use. It is an error/undefined behavior
Review comment:
"undefined behavior" sounds a bit scary given the baggage this term has
in C/C++. Perhaps say that the behavior can be implement-dependent and that
implementations are allowed to raise an error?
##########
File path: format/Flight.proto
##########
@@ -280,9 +287,20 @@ message FlightEndpoint {
Ticket ticket = 1;
/*
- * A list of URIs where this ticket can be redeemed. If the list is
- * empty, the expectation is that the ticket can only be redeemed on the
- * current service where the ticket was generated.
+ * A list of URIs where this ticket can be redeemed.
Review comment:
Perhaps also explain how someone is supposed to "redeem" a ticket (note
that verb doesn't seem to exist in the RPC APIs)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
