alamb opened a new pull request #2052:
URL: https://github.com/apache/arrow-datafusion/pull/2052


   Draft PR until https://github.com/apache/arrow-datafusion/pull/2050 is merged
   
   # Which issue does this PR close?
   
   Closes https://github.com/apache/arrow-datafusion/pulls
   
    # Rationale for this change
   
   We have a custom catalog implementation in IOx that implements 
`SchemaProvider`. However, in our usecase I don't want to allow users to 
register new schemas via SQL (and would like to return an Error about 'not 
supported')
   
   However, the current API only returns a `Option`:
   
   
https://github.com/apache/arrow-datafusion/blob/3ec0d55c736aecef5051311e639836aecbde7f51/datafusion/src/catalog/catalog.rs#L150-L154
   
   # What changes are included in this PR?
   1. return a `Result<Option<.>>` and default the implementation to 
"registering new schemas is not supported"
   2. tests for same
   
   
   # Are there any user-facing changes?
   Yes, changes the API introduced by @matthewmturner in 
https://github.com/apache/arrow-datafusion/pull/1959 but that has not yet been 
released publically


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to