jackwener commented on a change in pull request #2054:
URL: https://github.com/apache/arrow-datafusion/pull/2054#discussion_r831943754
##########
File path: datafusion/src/logical_plan/builder.rs
##########
@@ -916,7 +916,11 @@ impl LogicalPlanBuilder {
/// Build the plan
pub fn build(&self) -> Result<LogicalPlan> {
- Ok(self.plan.clone())
+ if let Some(err) = check_plan_invalid(&self.plan) {
Review comment:
> If you mean Result<(), DataFusionError>, I think it's the same as
Option, right?
Yes, A `result` represent either success/ Ok or failure/ Err. It's more
elegant and reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
