dragosmg commented on a change in pull request #12506:
URL: https://github.com/apache/arrow/pull/12506#discussion_r832205490
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -233,6 +236,68 @@ register_bindings_datetime <- function() {
tz = "UTC") {
call_binding("make_datetime", year, month, day, hour, min, sec, tz)
})
+ register_binding("difftime", function(time1,
+ time2,
+ tz,
+ units = "secs") {
+ if (units != "secs") {
+ abort("`difftime()` with units other than `secs` not supported in Arrow")
+ }
+
+ if (!missing(tz)) {
+ warn("`tz` argument is not supported in Arrow, so it will be ignored")
+ }
+
+ # cast to timestamp if time1 and time2 are not dates or timpestamp
expressions
+ # (the subtraction of which would output a `duration`)
+ if (!(inherits(time1, "Expression") &&
+ time1$type_id() %in% Type[c("TIMESTAMP", "DATE32", "DATE64")])) {
+ time1 <- build_expr("cast", time1, options = cast_options(to_type =
timestamp(timezone = "UTC")))
+ }
+
+ if (!(inherits(time2, "Expression") &&
+ time2$type_id() %in% Type[c("TIMESTAMP", "DATE32", "DATE64")])) {
+ time2 <- build_expr("cast", time2, options = cast_options(to_type =
timestamp(timezone = "UTC")))
+ }
Review comment:
on a second thought, the `"is.instant"` binding + `"subtract_checked"`
Expression isn't that clunky and a bit cleaner, so we could go with that:
```r
if (!call_binding("is.instant", time1)) {
time1 <- build_expr("cast", time1, options = cast_options(to_type =
timestamp(timezone = "UTC")))
}
if (!call_binding("is.instant", time2)) {
time2 <- build_expr("cast", time2, options = cast_options(to_type =
timestamp(timezone = "UTC")))
}
# we need to do this instead of `time1 - time2` to prevent complaints
when
# we try to subtract an R object from an Expression
subtract_output <- build_expr("subtract_checked", time1, time2)
build_expr("cast", subtract_output, options = cast_options(to_type =
duration("s")))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
