lafiona opened a new pull request #12693: URL: https://github.com/apache/arrow/pull/12693
## Overview The goal of this pull request is to add functionality to `dev/merge_arrow_pr.py`, that checks individual commit messages for "Co-authored-by:" tags, when creating the squashed commit message when merging a pull request. This will ensure that all authors are included in the final commit message, to make sure they are acknowledged for their contributions. ## Implementation 1. Use the [`trailers`](https://git-scm.com/docs/git-log#Documentation/git-log.txt-emtrailersoptionsem) options of `git log` to check for the [`Co-authored-by` trailer](https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors). The equivalent `git` command is: `git log HEAD..<pull-request-branch> --pretty="%(trailers:key=Co-authored-by,valueonly)"` 2. For each commit in `<pull-request-branch>`, this command prints the value of any `Co-authored-by` trailers, which should be in the form of `<name> <<email-address>>`. 3. The values returned by this command are appended to the list of all commit authors. ## Testing I attempted to qualify the changes to `merge_arrow_pr.py` by taking the the following steps: 1. Created a branch for this change, [ARROW-13564](https://github.com/mathworks/arrow/tree/ARROW-13564) and corresponding [pull request](https://github.com/apache/arrow/pull/12682). 3. Set the DEBUGGING environment variable to `1`. 4. Following the steps within `merge_arrow_pr.py`, I run the merge script from an `apache/arrow` cloned repository and receive an error that (I believe) is indicating I do not have necessary repository permissions to continue with the merge request: ``` Proceed with merging pull request #12682? (y/n): y fatal: 'apache' does not appear to be a git repository fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Command failed: ['git', 'fetch', 'apache', 'pull/12682/head:PR_TOOL_MERGE_PR_12682'] ``` I am not able to reach the step where the new commit message is created. Do you have any advice for qualifying this change? ## Notes Thank you @kevingurney for your help with this pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
