pitrou commented on a change in pull request #12678:
URL: https://github.com/apache/arrow/pull/12678#discussion_r832639736
##########
File path: cpp/src/arrow/testing/gtest_util.h
##########
@@ -120,6 +120,11 @@
ASSIGN_OR_HANDLE_ERROR_IMPL( \
ASSERT_OK, ARROW_ASSIGN_OR_RAISE_NAME(_error_or_value, __COUNTER__),
lhs, rexpr);
+#define ASSERT_OK_NO_THROW_AND_ASSIGN(lhs, rexpr)
\
+ ASSIGN_OR_HANDLE_ERROR_IMPL(ASSERT_OK_NO_THROW,
\
Review comment:
I don't think so actually, it was probably a misunderstanding when those
tests were written (besides, Arrow C++ shouldn't throw any exceptions of its
own).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
