jorisvandenbossche commented on a change in pull request #12483: URL: https://github.com/apache/arrow/pull/12483#discussion_r832981286
########## File path: docs/source/conf.py ########## @@ -277,7 +278,8 @@ html_static_path = ['_static'] # Custom fixes to the RTD theme -html_css_files = ['theme_overrides.css'] +html_css_files = ['theme_overrides.css', + 'https://cdnjs.cloudflare.com/ajax/libs/font-awesome/4.7.0/css/font-awesome.min.css'] Review comment: Ah, I see. I think it is fine to keep them. In this dropdown, I suppose you cannot easily use a downloaded image as you did for the others? Now, the theme itself should normally also already include fontawesome. So I would still think that it would even work as is without the above line. For example, if you look at [view-source:https://alenkaf.github.io/arrow-dev-docs-preview/html/developers/contributing.html](view-source:https://alenkaf.github.io/arrow-dev-docs-preview/html/developers/contributing.html), there is already some other `/vendor/fontawesome/..` css included as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
