rok commented on a change in pull request #12536:
URL: https://github.com/apache/arrow/pull/12536#discussion_r833309715



##########
File path: ci/appveyor-cpp-setup.bat
##########
@@ -115,3 +115,17 @@ powershell.exe -Command "Start-Process clcache-server" || 
exit /B
 if "%ARROW_S3%" == "ON" (
     appveyor DownloadFile 
https://dl.min.io/server/minio/release/windows-amd64/minio.exe -FileName 
C:\Windows\Minio.exe || exit /B
 )
+
+
+@rem
+@rem Download IANA Timezone Database for unit tests
+@rem
+@rem (Doc section: Download timezone database)
+curl https://data.iana.org/time-zones/releases/tzdata2021e.tar.gz --output 
tzdata.tar.gz

Review comment:
       Currently US and EU have DST, but they plan to abolish it soon. At that 
point we will have Python and R DBs with fresh DSTless times and arrow c++ 
using DST for tests. In isolation that's ok, but we do have tests comparing 
pandas and pyarrow results and similar for lubridate. It's not a big problem 
for sure, but if there is like a tzdata-latest.tar.gz that would be great.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to