tustvold commented on a change in pull request #1477:
URL: https://github.com/apache/arrow-rs/pull/1477#discussion_r833585589



##########
File path: parquet/src/arrow/levels.rs
##########
@@ -757,7 +757,10 @@ impl LevelInfo {
 
     /// Given a level's information, calculate the offsets required to index 
an array correctly.
     pub(crate) fn filter_array_indices(&self) -> Vec<usize> {

Review comment:
       This function only makes sense for writing leaf arrays, and so I worry 
that whilst this may fix the case of a List of nulls, it will behave 
erratically if given a list of non-nulls. I'll see if I can work out why this 
method is getting called at all




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to