sanjibansg commented on a change in pull request #12530:
URL: https://github.com/apache/arrow/pull/12530#discussion_r833819829
##########
File path: cpp/src/arrow/dataset/partition_test.cc
##########
@@ -291,7 +293,23 @@ TEST_F(TestPartitioning, DiscoverSchema) {
AssertInspect({"/0/1", "/hello"}, {Str("alpha"), Int("beta")});
}
-TEST_F(TestPartitioning, DictionaryInference) {
+TEST_F(TestPartitioning, DiscoverSchemaFilename) {
+ factory_ = FilenamePartitioning::MakeFactory({"alpha", "beta"});
+
+ // type is int32 if possible
+ AssertInspect({"0_1_"}, {Int("alpha"), Int("beta")});
+
+ // extra segments are ignored
+ AssertInspect({"0_1_what_"}, {Int("alpha"), Int("beta")});
+
+ // fall back to string if any segment for field alpha is not parseable as int
+ AssertInspect({"0_1_", "hello_1_"}, {Str("alpha"), Int("beta")});
+
+ // If there are too many digits fall back to string
+ AssertInspect({"3760212050_1_"}, {Str("alpha"), Int("beta")});
+}
Review comment:
Modified tests to check for invalid syntax and incomplete fields.
I think we only have tests on URI encoding in HivePartitioning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
