andygrove commented on pull request #7967: URL: https://github.com/apache/arrow/pull/7967#issuecomment-675035668
Currently we only do optimizations on the logical plan, but there is a plan to have physical plan optozations as well. On Mon, Aug 17, 2020, 11:37 AM Jorge Leitao <[email protected]> wrote: > *@jorgecarleitao* commented on this pull request. > ------------------------------ > > In rust/datafusion/src/sql/planner.rs > <https://github.com/apache/arrow/pull/7967#discussion_r471652148>: > > > @@ -515,27 +515,29 @@ impl<S: SchemaProvider> SqlToRel<S> { > } > _ => match self.schema_provider.get_function_meta(&name) { > Some(fm) => { > - let rex_args = function > > AFAI recall, optimizations happen on the logical plan alone. Also, I think > that 52218c8 > <https://github.com/apache/arrow/commit/52218c852b7b3016afeaf95d8a46d6deea89d231> > removes the coercion in constructing the logical, not physical, plan (SQL > nodes -> physical). > > If this is the case, logical -> physical does not have to worry about > these, right? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/arrow/pull/7967#discussion_r471652148>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAHEBRG3AGK3SB5ZALBMEUTSBFTEDANCNFSM4QAG5BEA> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
