vibhatha commented on a change in pull request #12672: URL: https://github.com/apache/arrow/pull/12672#discussion_r834277072
########## File path: cpp/src/arrow/engine/substrait/util.h ########## @@ -0,0 +1,90 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include "arrow/api.h" +#include "arrow/compute/api.h" +#include "arrow/engine/api.h" +#include "arrow/util/async_generator.h" +#include "arrow/util/iterator.h" + +namespace arrow { + +namespace cp = arrow::compute; + +namespace engine { + +class ARROW_ENGINE_EXPORT SubstraitSinkConsumer : public cp::SinkNodeConsumer { + public: + explicit SubstraitSinkConsumer( + AsyncGenerator<arrow::util::optional<cp::ExecBatch>>* generator, + arrow::util::BackpressureOptions backpressure = {}) + : producer_(MakeProducer(generator, std::move(backpressure))) {} + + Status Consume(cp::ExecBatch batch) override; + + static arrow::PushGenerator<arrow::util::optional<cp::ExecBatch>>::Producer + MakeProducer(AsyncGenerator<arrow::util::optional<cp::ExecBatch>>* out_gen, + arrow::util::BackpressureOptions backpressure) { + arrow::PushGenerator<arrow::util::optional<cp::ExecBatch>> push_gen( + std::move(backpressure)); + auto out = push_gen.producer(); + *out_gen = std::move(push_gen); + return out; + } + + Future<> Finish() override; + + private: + PushGenerator<arrow::util::optional<cp::ExecBatch>>::Producer producer_; +}; + +class ARROW_ENGINE_EXPORT SubstraitExecutor { + public: + explicit SubstraitExecutor( + std::string substrait_json, + AsyncGenerator<arrow::util::optional<cp::ExecBatch>>* generator, + std::shared_ptr<cp::ExecPlan> plan, std::shared_ptr<Schema> schema, + cp::ExecContext exec_context) + : substrait_json_(substrait_json), + generator_(generator), + plan_(std::move(plan)), + schema_(schema), + exec_context_(exec_context) {} + + Status MakePlan(); + + Result<std::shared_ptr<RecordBatchReader>> Execute(); + + Status Finalize(); + + static Result<std::shared_ptr<RecordBatchReader>> GetRecordBatchReader( + std::string& substrait_json, std::shared_ptr<arrow::Schema> schema); Review comment: I agree with you. I am still trying to work that out. It is not 100% clear to me how to infer the output schema from the plan. I am working on those details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
