yahoNanJing commented on a change in pull request #2076:
URL: https://github.com/apache/arrow-datafusion/pull/2076#discussion_r834383462
##########
File path: datafusion-storage/src/lib.rs
##########
@@ -18,7 +18,10 @@
pub mod object_store;
use chrono::{DateTime, Utc};
-use datafusion_common::ScalarValue;
+use std::{io, result};
+
+/// Result type for operations that could result in an io error
+pub type Result<T> = result::Result<T, io::Error>;
Review comment:
The goal of this PR is to remove the datafusion-common dependency.
When you need to use DataFusionError::IoError, it's simply to add
*.map_err(DataFusionError::IoError)* like some places in this PR does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
