jorgecarleitao commented on a change in pull request #7974:
URL: https://github.com/apache/arrow/pull/7974#discussion_r471708549
##########
File path: rust/datafusion/src/logicalplan.rs
##########
@@ -355,7 +355,7 @@ pub enum Expr {
/// List of expressions to feed to the functions as arguments
args: Vec<Expr>,
/// The `DataType` the expression will yield
- return_type: DataType,
+ return_type: ReturnType,
Review comment:
THIS IS A MAJOR CHANGE: it makes Expr hold an `Arc<&dyn>`, which make
them unserializable. I was unable to find another way, unfortunately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
