silence-coding commented on pull request #2066:
URL: 
https://github.com/apache/arrow-datafusion/pull/2066#issuecomment-1078619260


   > Sadly I think #2023 added 3.json already -- can you fix this PR to use the 
name `4.json`?
   > 
   > like:
   > 
   > ```diff
   > --- a/datafusion/src/datasource/file_format/json.rs
   > +++ b/datafusion/src/datasource/file_format/json.rs
   > @@ -236,7 +236,7 @@ mod tests {
   >  
   >      #[tokio::test]
   >      async fn infer_schema_with_limit()  {
   > -        let filename = "tests/jsons/3.json";
   > +        let filename = "tests/jsons/4.json";
   >          let format = JsonFormat::default()
   >              .with_schema_infer_max_rec(Some(3));
   >          let file_schema = format
   > diff --git a/datafusion/tests/jsons/3.json b/datafusion/tests/jsons/4.json
   > similarity index 100%
   > rename from datafusion/tests/jsons/3.json
   > rename to datafusion/tests/jsons/4.json
   > ```
   > 
   > to resolve the conflict?
   
   fix with schema_infer_limit.json


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to