HaoYang670 opened a new issue #1727:
URL: https://github.com/apache/arrow-datafusion/issues/1727


   **Describe the bug**
   I find that we have 2 same tests:
   ```rust
           // check that non foldable arguments are folded
           // to_timestamp(a) --> to_timestamp(a) [no rewrite possible]
           let expr = Expr::ScalarFunction {
               args: vec![col("a")],
               fun: BuiltinScalarFunction::ToTimestamp,
           };
           test_evaluate(expr.clone(), expr);
   
   
           // check that non foldable arguments are folded
           // to_timestamp(a) --> to_timestamp(a) [no rewrite possible]
           let expr = Expr::ScalarFunction {
               args: vec![col("a")],
               fun: BuiltinScalarFunction::ToTimestamp,
           };
           test_evaluate(expr.clone(), expr);
   ```
   
https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/optimizer/simplify_expressions.rs#L1026-L1040
   
   **To Reproduce**
   
   **Expected behavior**
   Remove one of the test or add some comment about why we need 2 same tests.
   
   **Additional context**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to