dragosmg commented on pull request #12402: URL: https://github.com/apache/arrow/pull/12402#issuecomment-1078776962
I think several things are needed here: - [ ] new unit tests to show similar behaviour (returning `NA` in the same circumstances) - [ ] update existing unit tests. These are not using `compare_dplyr_binding()` and are not catching the fact that Arrow's `strptime` (`datetime`) binding returns a different class that `base::strptime()` (`POSIXlt`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
