alamb commented on a change in pull request #2082:
URL: https://github.com/apache/arrow-datafusion/pull/2082#discussion_r835460955



##########
File path: docs/source/user-guide/sql/aggregate_functions.md
##########
@@ -0,0 +1,69 @@
+# Aggregate Functions
+
+Aggregate functions operate on a set of values to compute a single result.
+
+## General
+
+### min

Review comment:
       I think writing nice / proper documentation for SQL is a large 
undertaking.
   
   For standard SQL functions, perhaps we can simply link to pre-existing 
documentation, such as: 
https://www.postgresql.org/docs/current/functions-aggregate.html and focus 
DataFusion documentation on what is different / specific to datafusion (such 
as`approx_percentile_cont`, `approx_median` and 
`approx_percentile_cont_with_weight`)?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to