ateucher commented on a change in pull request #12711:
URL: https://github.com/apache/arrow/pull/12711#discussion_r835482760
##########
File path: r/tests/testthat/test-dplyr-funcs-string.R
##########
@@ -248,14 +254,26 @@ test_that("grepl with ignore.case = TRUE and fixed =
TRUE", {
expect_equal(
df %>%
Table$create() %>%
- filter(x = grepl("^B.+", x, ignore.case = TRUE, fixed = TRUE)) %>%
+ filter(grepl("^B.+", x, ignore.case = TRUE, fixed = TRUE)) %>%
collect(),
tibble(x = character(0))
)
+ expect_equal(
+ df %>%
+ Table$create() %>%
+ mutate(
+ a = grepl("O", x, ignore.case = TRUE, fixed = TRUE)
+ ) %>%
+ collect(),
+ tibble(
+ x = c("Foo", "bar", NA_character_),
+ a = c(TRUE, FALSE, FALSE)
+ )
+ )
Review comment:
Given that base `grepl` gives that warning when `ignore.case = TRUE` and
`fixed = TRUE`, should the binding for `grepl` (as well as for `sub` and
`gsub`) also emit that warning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
