jychen7 commented on a change in pull request #2099: URL: https://github.com/apache/arrow-datafusion/pull/2099#discussion_r835851145
########## File path: datafusion/src/sql/parser.rs ########## @@ -192,6 +194,35 @@ impl<'a> DFParser<'a> { } } + fn parse_partitions(&mut self) -> Result<Vec<String>, ParserError> { Review comment: similar to `parse_columns`. I didn't reuse `parse_columns` because partitions only have identifier/name, there is no type or other options like column https://github.com/apache/arrow-datafusion/blob/f50e8000ee4de8432d7b59b63c18a8e0171a072b/datafusion/src/sql/parser.rs#L227-L229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org