dhruv9vats commented on a change in pull request #12724:
URL: https://github.com/apache/arrow/pull/12724#discussion_r835872552
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -2262,8 +2262,7 @@ TEST(Cast, StructToSameSizedButDifferentNamedStruct) {
EXPECT_RAISES_WITH_MESSAGE_THAT(
TypeError,
- ::testing::HasSubstr("Type error: struct field names do not match:
struct<a: int8, "
- "b: int8> struct<c: int8, d: int8>"),
+ ::testing::HasSubstr("struct (sub)fields don't match or are in the wrong
order"),
Review comment:
This makes me think, should we just extend the already existing
`CastStruct` implementation?
##########
File path: cpp/src/arrow/compute/kernels/scalar_cast_test.cc
##########
@@ -2262,8 +2262,7 @@ TEST(Cast, StructToSameSizedButDifferentNamedStruct) {
EXPECT_RAISES_WITH_MESSAGE_THAT(
TypeError,
- ::testing::HasSubstr("Type error: struct field names do not match:
struct<a: int8, "
- "b: int8> struct<c: int8, d: int8>"),
+ ::testing::HasSubstr("struct (sub)fields don't match or are in the wrong
order"),
Review comment:
To make the tests pass, because this kind of extends the already
implemented `CastStruct`.
(Ditto below and in `dataset/scanner_test.cc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
