dragosmg edited a comment on pull request #12402:
URL: https://github.com/apache/arrow/pull/12402#issuecomment-1078776962
I think several things are needed:
- [ ] new unit tests to show similar behaviour (returning `NA` in the same
circumstances)
- [ ] update existing unit tests. These are not using
`compare_dplyr_binding()` and are not catching the fact that Arrow's `strptime`
binding returns an object of a different class (`POSIXct`, a double vector)
that `base::strptime()` (`POSIXlt`, a list)
`waldo::compare()` does ignore `class` when `ignore_attr = TRUE`, but it
can't ignore `typeof`. I don't think we want to change the type of object
Arrow's `strptime` binding returns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
