zagto commented on a change in pull request #12669:
URL: https://github.com/apache/arrow/pull/12669#discussion_r836571968
##########
File path: cpp/src/arrow/flight/flight_internals_test.cc
##########
@@ -177,6 +175,25 @@ TEST(FlightTypes, RoundtripStatus) {
ASSERT_THAT(status.message(), ::testing::HasSubstr("Sentinel"));
}
+ARROW_SUPPRESS_DEPRECATION_WARNING
+TEST(FlightTypes, DeprecatedLocationConstruction) {
+ Location location;
+ ASSERT_NOT_OK(Location::Parse("This is not an URI", &location));
Review comment:
yes makes sense, I'll update them.
Looking at it, I think I'll also at a test for the non-deprecated variants,
since I don't see that explicitly tested anywhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
