lidavidm commented on a change in pull request #12669:
URL: https://github.com/apache/arrow/pull/12669#discussion_r836618819
##########
File path: cpp/src/arrow/flight/server.h
##########
@@ -237,11 +244,13 @@ class ARROW_FLIGHT_EXPORT FlightServerBase {
/// \brief Retrieve the schema for the indicated descriptor
/// \param[in] context The call context.
/// \param[in] request may be null
- /// \param[out] schema the returned flight schema provider
- /// \return Status
- virtual Status GetSchema(const ServerCallContext& context,
- const FlightDescriptor& request,
- std::unique_ptr<SchemaResult>* schema);
+ /// \return Arrow result with the returned flight schema provider
+ virtual arrow::Result<std::unique_ptr<SchemaResult>> GetSchema(
Review comment:
For anything which is meant to be overridden, I think we should not
change the signatures, so yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
