save-buffer commented on a change in pull request #12605:
URL: https://github.com/apache/arrow/pull/12605#discussion_r836951571
##########
File path: cpp/thirdparty/versions.txt
##########
@@ -121,7 +121,7 @@ DEPENDENCIES=(
"ARROW_GLOG_URL glog-${ARROW_GLOG_BUILD_VERSION}.tar.gz
https://github.com/google/glog/archive/${ARROW_GLOG_BUILD_VERSION}.tar.gz";
"ARROW_GOOGLE_CLOUD_CPP_URL
google-cloud-cpp-${ARROW_GOOGLE_CLOUD_CPP_BUILD_VERSION}.tar.gz
https://github.com/googleapis/google-cloud-cpp/archive/refs/tags/${ARROW_GOOGLE_CLOUD_CPP_BUILD_VERSION}.tar.gz";
"ARROW_GRPC_URL grpc-${ARROW_GRPC_BUILD_VERSION}.tar.gz
https://github.com/grpc/grpc/archive/${ARROW_GRPC_BUILD_VERSION}.tar.gz";
- "ARROW_GTEST_URL gtest-${ARROW_GTEST_BUILD_VERSION}.tar.gz
https://github.com/google/googletest/archive/release-${ARROW_GTEST_BUILD_VERSION}.tar.gz";
+ "ARROW_GTEST_URL {ARROW_GTEST_BUILD_VERSION}.zip
https://github.com/google/googletest/archive/${ARROW_GTEST_BUILD_VERSION}.zip";
Review comment:
Switched it.
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1850,12 +1849,6 @@ macro(build_gtest)
set(GTEST_VENDORED TRUE)
set(GTEST_CMAKE_CXX_FLAGS ${EP_CXX_FLAGS})
- if(CMAKE_BUILD_TYPE MATCHES DEBUG)
- set(CMAKE_GTEST_DEBUG_EXTENSION "d")
- else()
- set(CMAKE_GTEST_DEBUG_EXTENSION "")
- endif()
-
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
