jhorstmann commented on a change in pull request #1494:
URL: https://github.com/apache/arrow-rs/pull/1494#discussion_r837863843
##########
File path: arrow/src/alloc/mod.rs
##########
@@ -121,3 +124,30 @@ pub unsafe fn reallocate<T: NativeType>(
handle_alloc_error(Layout::from_size_align_unchecked(new_size,
ALIGNMENT))
})
}
+
+/// The owner of an allocation, that is not natively allocated.
+/// The trait implementation is responsible for dropping the allocations once
no more references exist.
+pub trait Allocation: RefUnwindSafe {}
Review comment:
Other names I had considered were `Owner` or `AllocationOwner`. The
`Native` / `Foreign` terminology no longer fits nicely, at least I consider a
Rust `Vec` to be more "native" than our custom allocator.
Maybe we could rename the `Deallocation` variants to make this clearer. The
enum was in a non-public module before (and should probably stay `pub(crate)`).
I'm thinking of `Arrow(usize)` and `Custom(Arc<dyn Allocation>)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
