dragosmg commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r839361095
##########
File path: r/tests/testthat/test-Array.R
##########
@@ -260,18 +260,28 @@ test_that("array supports POSIXct (ARROW-3340)", {
expect_array_roundtrip(times2, timestamp("us", "US/Eastern"))
})
-test_that("array supports POSIXct without timezone", {
- # Make sure timezone is not set
+test_that("array uses local timezone for POSIXct without timezone", {
withr::with_envvar(c(TZ = ""), {
times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") +
1:10
- expect_array_roundtrip(times, timestamp("us", ""))
+ expect_equal(attr(times, "tzone"), NULL)
+ expect_array_roundtrip(times, timestamp("us", Sys.timezone()))
# Also test the INTSXP code path
skip("Ingest_POSIXct only implemented for REALSXP")
times_int <- as.integer(times)
attributes(times_int) <- attributes(times)
expect_array_roundtrip(times_int, timestamp("us", ""))
})
+ withr::with_envvar(c(TZ = "Pacific/Marquesas"), {
+ times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") +
1:10
+ expect_equal(attr(times, "tzone"), "Pacific/Marquesas")
+ expect_array_roundtrip(times, timestamp("us", "Pacific/Marquesas"))
+ })
+ withr::with_envvar(c(TZ = NA), {
+ times <- strptime("2019-02-03 12:34:56", format = "%Y-%m-%d %H:%M:%S") +
1:10
+ expect_equal(attr(times, "tzone"), NULL)
+ expect_array_roundtrip(times, timestamp("us", Sys.timezone()))
+ })
Review comment:
Used `with::with_timezone()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
